Skip to content

visualizer/osg: fix build against omnetpp topic/VSG (osg::Node fwd-decl removed from cenvir.h) #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tabgab wants to merge 1 commit into
base: fix/osg-vsg-coexist
Choose a base branch
from
+3 −0
Open

visualizer/osg: fix build against omnetpp topic/VSG (osg::Node fwd-decl removed from cenvir.h) #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/inet/visualizer/osg/common/PacketDropOsgVisualizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#ifndef __INET_PACKETDROPOSGVISUALIZER_H
#define __INET_PACKETDROPOSGVISUALIZER_H

#include <osg/Node>

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Other OSG visualizer headers may have the same missing include

This PR fixes three headers that use osg::Node without explicitly including <osg/Node>. It's worth checking whether other OSG visualizer headers in the codebase have the same latent issue — relying on transitive includes for osg::Node. For example, other files under src/inet/visualizer/osg/ that use osg::ref_ptr<osg::Node> may also be missing the direct include and could break if upstream OSG headers change their transitive include structure.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

#include <osg/ref_ptr>

#include "inet/visualizer/base/PacketDropVisualizerBase.h"
Expand Down
1 change: 1 addition & 0 deletions src/inet/visualizer/osg/linklayer/LinkBreakOsgVisualizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#ifndef __INET_LINKBREAKOSGVISUALIZER_H
#define __INET_LINKBREAKOSGVISUALIZER_H

#include <osg/Node>
#include <osg/ref_ptr>

#include "inet/visualizer/base/LinkBreakVisualizerBase.h"
Expand Down
1 change: 1 addition & 0 deletions src/inet/visualizer/osg/networklayer/RoutingTableOsgVisualizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#ifndef __INET_ROUTINGTABLEOSGVISUALIZER_H
#define __INET_ROUTINGTABLEOSGVISUALIZER_H

#include <osg/Node>
#include <osg/ref_ptr>

#include "inet/visualizer/base/RoutingTableVisualizerBase.h"
Expand Down