[codex] Make rumple a gridded metric#54
Draft
iosefa wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
calculate_rumpleconsistent with the other gridded forest-structure metrics.The released
v0.4.1implementation calculated one scalar rumple value from an existing CHM. This changes the public API so callers provide point-cloud data andvoxel_resolution, and receive a 2D rumple raster plus extent, matching the pattern used by CHM/PAI/FHD-style outputs.Changes
calculate_rumple(points, voxel_resolution, min_height=None)to return(rumple, extent).X,Y, andHeightAboveGround.metric="rumple"support toprocess_with_tiles.Ground Area
Within each output cell, ground area is now the summed projected planar area of valid Delaunay triangles formed by the points in that cell. It is not the full rectangular cell footprint. This keeps a flat but irregularly sampled point surface at rumple
1.0, while cells with fewer than three unique point locations returnNaN.Validation
python -m pytest tests/test_calculate.py -qpassed: 54 passed, 1 warning.python -m py_compile pyforestscan/calculate.py pyforestscan/process.py pyforestscan/__init__.pygit diff --check