more guidance for clankers in lint errors - #31
Merged
Conversation
…idanceforclankersinlinterrors
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 442d3fd. Configure here.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Lint failures now give concrete spinnerWaiter guidance instead of only naming the violated rule.
prefer-locator-waitsexplains why locator-native waits work better with spinnerWaiter.require-timeout-commentlists fixes for existing, missing, slow, custom, and disabled loading UI.prefer-positive-waitsexplains how to replace or justify detached waits.The lint text keeps the existing docs links and key remediation phrases so downstream expectations remain stable.
Verification
pnpm lintpnpm typecheckpnpm buildpnpm exec publintpnpm test— 144 passed, 3 skippedTodo-app video baseline
video-rendered.webm
Codex session: PR #31 dedent and CI fix —
01a00070-794d-7b52-ae0a-2ff6f97ba972Note
Low Risk
Changes are limited to lint message strings and a formatting test; detection, fixes, and required-pattern matching are untouched.
Overview
Lint rule messages are rewritten so failures give actionable spinnerWaiter guidance instead of short rule reminders.
prefer-locator-waitsone-line messages now mention benefiting from spinnerWaiter’s loading UI detection.require-timeout-commentandprefer-positive-waitsusededentfor multi-step remediation (remove timeouts, add loading UI,spinnerWaiter.settings.runoptions, comment patterns, and docs links). Rule logic and autofix behavior are unchanged.A new spec asserts multiline messages are trimmed and have no indented lines, so oxlint output stays readable.
Reviewed by Cursor Bugbot for commit e9d224b. Bugbot is set up for automated code reviews on this repo. Configure here.