Improve speed of hasattr on IDS structures - #140
Open
maarten-ic wants to merge 1 commit into
Open
Conversation
Replace `_path` (which constructs the path including AoS indices) with the static `metadata.path_string` when an attribute cannot be found.
Speeds up the following sample from 110ms to 0.5ms (200x gain):
```python
import timeit
import imas
cp = imas.IDSFactory().core_profiles()
cp.profiles_1d.resize(1000)
def totime():
hasattr(cp.profiles_1d[999], "xyz")
print(timeit.repeat(totime, number=1000))
```
**Changed behaviour:**
Before: `AttributeError: IDS structure 'profiles_1d[999]' has no attribute 'xyz'`
After: `AttributeError: IDS structure 'profiles_1d' has no attribute 'xyz'`
Since the index of an AoS is not relevant for whether an attribute exists or not, I believe this is not a problem.
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
August 5, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
_path(which constructs the path including AoS indices) with the staticmetadata.path_stringwhen an attribute cannot be found.Speeds up the following sample from 110ms to 0.5ms (200x gain):
Changed behaviour:
Before:
AttributeError: IDS structure 'profiles_1d[999]' has no attribute 'xyz'After:AttributeError: IDS structure 'profiles_1d' has no attribute 'xyz'Since the index of an AoS is not relevant for whether an attribute exists or not, I believe this is not a problem.