Fix/server version endpoint - #115
Closed
khalsz wants to merge 2 commits into
Closed
Conversation
khalsz
requested review from
SimonPinches,
Yannicked,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
August 6, 2026 11:24
Contributor
|
Thanks @khalsz, I think this makes sense altogether to a a single server version endpoint at the root rather than for each API version. Do you agree with it @Yannicked ? Before proceeding further this would need to be rebased (because of #113 which fixed a different issue), it would need to fix the tests with broken assertions and also remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR help move the server_version metadata to the server homepage, and fixed the
get_server_versionfunction to request from the server homepage rather than the api version index page.