Export to static IDS nodes - #186
Open
SBlokhuizen wants to merge 1 commit into
Open
Conversation
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
August 3, 2026 14:14
SBlokhuizen
force-pushed
the
feature/static-ids-nodes
branch
from
August 5, 2026 11:38
8fa14c3 to
c56790f
Compare
Collaborator
|
Could we reduce complexity by introducing a ConstantWaveform subclass (see shorthand notation) and require that instead of checking for a single constant tendency in the export? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow exporting to non-time-dependent 0D IDS nodes. These waveforms may only consist of a single constant tendency, e.g.