Skip to content

Fix connection to ClientDisconnected signal#3760

Merged
ann0see merged 1 commit into
mainfrom
dingodoppelt-patch-1
Jun 30, 2026
Merged

Fix connection to ClientDisconnected signal#3760
ann0see merged 1 commit into
mainfrom
dingodoppelt-patch-1

Conversation

@dingodoppelt

@dingodoppelt dingodoppelt commented Jun 29, 2026

Copy link
Copy Markdown
Member

Short description of changes

Fixes a regression in jamulusserver/clientDisconnected

CHANGELOG: Fix connection to ClientDisconnected signal

Status of this Pull Request

Ready to be merged

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see requested a review from pljones June 29, 2026 20:24
@dingodoppelt

Copy link
Copy Markdown
Member Author

Reintroducing this as a receiver into the connect function makes Qt::AutoConnection use Qt::QueuedConnection for connections across threads instead of Qt::DirectConnection
https://doc.qt.io/qt-6/qt.html#ConnectionType-enum

@dingodoppelt dingodoppelt requested a review from ann0see June 30, 2026 17:53
@ann0see ann0see added this to the Release 4.0.0 milestone Jun 30, 2026
@ann0see ann0see added this to Tracking Jun 30, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Jun 30, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Waiting on Team in Tracking Jun 30, 2026
@ann0see ann0see moved this from Waiting on Team to Waiting externally in Tracking Jun 30, 2026
@ann0see ann0see merged commit 7d726cc into main Jun 30, 2026
13 checks passed
@ann0see ann0see deleted the dingodoppelt-patch-1 branch June 30, 2026 18:00
@github-project-automation github-project-automation Bot moved this from Waiting externally to Done in Tracking Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants