feat: add QR code generation tool#119
Merged
Merged
Conversation
andycreed0x
marked this pull request as draft
July 11, 2026 17:14
andycreed0x
marked this pull request as ready for review
July 15, 2026 17:05
coelhogonzalo
approved these changes
Jul 15, 2026
coelhogonzalo
left a comment
coelhogonzalo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Posted a concern about the safety of creating files outside /.aqua/qr but I could be wrong.
Can we do something about the color inversion in the QR? This could be problematic for some scanners. https://www.reddit.com/r/computers/comments/1asy597/qr_codes_not_working_upon_changing_color/
Genuinely curious, just bringing it up for you to think about it. Not a major deal so you have my approval
TomasCast
reviewed
Jul 16, 2026
TomasCast
left a comment
TomasCast
left a comment
Collaborator
There was a problem hiding this comment.
Approved with comments
Comment on lines
+1990
to
+1991
| qr_dir = output_dir or str(get_manager().storage.qr_dir) | ||
| path = generate_qr(data, qr_dir, filename=filename) |
Collaborator
There was a problem hiding this comment.
This function does not have any type of restriction on data's length. It may generate data overflow errors or similars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qr_generatetool that writes QR payloads to PNG filesTest Plan
uv run python -m pytest tests/test_cli.py::TestQrCommands tests/test_tools.py::TestToolRegistry -quv run python -m pytest tests/test_cli.py tests/test_tools.py -qNote:
uv run ruff check src testscurrently fails on pre-existing lint issues outside this change.Use:
uv run aqua qr generate bc1q5gwctjuryd8550ddne92wmm2ku6tjsaj8fqrft --terminal