update snapshot according to aria changes - #327
Closed
97th wants to merge 1 commit into
Closed
Conversation
97th
force-pushed
the
fix-update-snapshot
branch
from
April 16, 2026 08:59
9fafdad to
6a012d3
Compare
Collaborator
|
Thanks for taking the time to fix this! I went with #335 in the end — it keeps the full markup in the snapshots and only normalizes the timestamped focus-helper name, while the custom serializer here drops class/aria attributes from the snapshot, which is exactly the stuff that regressed last time. Appreciate the PR though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update snapshot according to aria changes
for passing https://github.com/jodit/jodit-react/actions/runs/23837412715