Add Siri AI (Apple Intelligence) completion model#44
Draft
boggedbrush wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FoundationModels/SystemLanguageModelAPI while preserving the macOS 14 deployment targetModelSetupCoordinator.swift, which the existing recursiveModels/ignore rule accidentally excluded from fresh clones, and scope that rule to the repository-root model directoryProvider behavior and safety
LanguageModelSessions so transcripts do not leak across keystrokes and overlapping calls do not collideS:/J:insertion-boundary protocol, then strip and validate it before presenting textValidation
swift build --package-path Packages/ConstrainedGeneration --target ConstrainedGenerationswift build --package-path Packages/Personalization --target PersonalizationKeyTypeTestsplutil -lint KeyType.xcodeproj/project.pbxprojgit diff --checkSystemLanguageModel.defaultsmoke checks on an eligible Mac:Please send->S:the fileI will see you tom->J:orrowThe capital of France is->S:Parislet pri->J:ntgit che->J:ckoutEnvironment limitation
The full Xcode app/test build could not be run in this environment because the installed Xcode beta license has not been accepted. The license was intentionally not accepted on the user's behalf. The active standalone Command Line Tools installation also lacks
XCTest, so package test runners could not execute; focused package builds, direct typechecks, parser checks, project lint, and the live on-device model smoke test were used instead.