Skip to content

fix(translator): honor APIKeyPassthrough for Gemini provider#2042

Open
mesutoezdil wants to merge 3 commits into
kagent-dev:mainfrom
mesutoezdil:fix/gemini-api-key-passthrough
Open

fix(translator): honor APIKeyPassthrough for Gemini provider#2042
mesutoezdil wants to merge 3 commits into
kagent-dev:mainfrom
mesutoezdil:fix/gemini-api-key-passthrough

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The Gemini provider in the model translator was not checking APIKeyPassthrough.
It always tried to mount the Google API key secret, even when passthrough mode was enabled.
It also never set APIKeyPassthrough on the ADK model struct.
All other providers (OpenAI, Anthropic, AzureOpenAI, Ollama) already handle this correctly.

Copilot AI review requested due to automatic review settings June 17, 2026 21:28
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jun 17, 2026
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jun 17, 2026
Copilot AI reviewed Jun 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Gemini model translation path so it correctly supports APIKeyPassthrough, aligning Gemini with the behavior already implemented for other providers in the ADK agent translator.

Changes:

  • Avoid injecting the Google API key env var/secret ref when APIKeyPassthrough is enabled (and only mount the secret when passthrough is off and a secret is configured).
  • Ensure the translated adk.Gemini model config reflects api_key_passthrough.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go/core/internal/controller/translator/agent/adk_api_translator.go
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch 2 times, most recently from adb6fd6 to ce7e91f Compare June 17, 2026 21:38
EItanya
EItanya reviewed Jun 18, 2026
View reviewed changes

@EItanya EItanya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, is passthrough implemented for Gemini in our adk + adk go?

@mesutoezdil

mesutoezdil commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense, is passthrough implemented for Gemini in our adk + adk go?

hm not fully. the python adk has the api_key_passthrough field on kagentgeminillm but is missing set_passthrough_key(), so llmassthroughplugin skips gemini at runtime. go adk has no gemini model implementation at all. my pr fixes the translator side only.
a follow-up is needed in the python adk to add set_passthrough_key() to kagentgeminillm.

@EItanya

EItanya commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Makes sense, is passthrough implemented for Gemini in our adk + adk go?

hm not fully. the python adk has the api_key_passthrough field on kagentgeminillm but is missing set_passthrough_key(), so llmassthroughplugin skips gemini at runtime. go adk has no gemini model implementation at all. my pr fixes the translator side only. a follow-up is needed in the python adk to add set_passthrough_key() to kagentgeminillm.

If this doesn't fully work then can we add those fixes?

@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch 2 times, most recently from 4781a44 to 4a2fc83 Compare June 18, 2026 14:44
@mesutoezdil

mesutoezdil commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense, is passthrough implemented for Gemini in our adk + adk go?

hm not fully. the python adk has the api_key_passthrough field on kagentgeminillm but is missing set_passthrough_key(), so llmassthroughplugin skips gemini at runtime. go adk has no gemini model implementation at all. my pr fixes the translator side only. a follow-up is needed in the python adk to add set_passthrough_key() to kagentgeminillm.

If this doesn't fully work then can we add those fixes?

done

@mesutoezdil mesutoezdil mentioned this pull request Jun 18, 2026
Open
6 tasks
@EItanya

EItanya commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

go adk has no gemini model implementation at all

How can this be true, seems like a bigger issue than passthrough in python

@mesutoezdil

mesutoezdil commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

go adk has no gemini model implementation at all

How can this be true, seems like a bigger issue than passthrough in python

correction: Go ADK does have Gemini (agent.go:215). What's missing is passthrough support there. it always requires env vars regardless of ApiKeyPassthrough. This PR covers translator + Python ADK; Go ADK passthrough is a separate follow-up.

@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 7, 2026 16:03
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch 5 times, most recently from 59391cd to dc85583 Compare July 10, 2026 16:33
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch 2 times, most recently from 1463b54 to 1e3c8e6 Compare July 10, 2026 18:27
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 10, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
881114b 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 13, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
ca8cd8a 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 881114b to ca8cd8a Compare July 13, 2026 07:37
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 13, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
8b7d9f3 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from ca8cd8a to 8b7d9f3 Compare July 13, 2026 10:20
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 13, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
87ffd2d 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 8b7d9f3 to 87ffd2d Compare July 13, 2026 12:56
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 14, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
f83247b 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 87ffd2d to f83247b Compare July 14, 2026 06:36
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 14, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
af41527 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from f83247b to af41527 Compare July 14, 2026 13:03
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 14, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
4d5de3f 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from eb645d4 to 4d5de3f Compare July 14, 2026 14:46
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 15, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
819aea7 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 4d5de3f to 819aea7 Compare July 15, 2026 07:28
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 15, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
7beddf6 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 819aea7 to 7beddf6 Compare July 15, 2026 18:24
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 15, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
bbade9d 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 7beddf6 to bbade9d Compare July 15, 2026 19:02
@mesutoezdil
fix(translator): honor APIKeyPassthrough for Gemini provider
c1b4977 
- skip Google API key secret mount when passthrough is enabled
- set api_key_passthrough on adk.Gemini model struct
- implement set_passthrough_key on KAgentGeminiLlm so LLMPassthroughPlugin works at runtime

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil added a commit to mesutoezdil/kagent that referenced this pull request Jul 15, 2026
@mesutoezdil
test(translator): update Gemini passthrough golden file registry to g…
3e3e145 
…hcr.io

cr.kagent.dev was removed in kagent-dev#2177; the golden file still referenced
the old alias, which caused go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from bbade9d to 3e3e145 Compare July 15, 2026 20:10
@mesutoezdil
test(translator): keep Gemini passthrough golden file in sync
240dc7d 
cr.kagent.dev was removed in kagent-dev#2177, and the app image tag changed to
app:dev. The golden file still had both old values, which caused
go-unit-tests to fail on PR kagent-dev#2042.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/gemini-api-key-passthrough branch from 3e3e145 to 240dc7d Compare July 16, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EItanya EItanya EItanya left review comments
Copilot code review Copilot Copilot left review comments
@supreme-gg-gg supreme-gg-gg Awaiting requested review from supreme-gg-gg
@iplay88keys iplay88keys Awaiting requested review from iplay88keys
@jmhbh jmhbh Awaiting requested review from jmhbh
@peterj peterj Awaiting requested review from peterj
@yuval-k yuval-k Awaiting requested review from yuval-k

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mesutoezdil @EItanya