Add configurable nodeSelector to substrate workloads#16
Open
the-mentor wants to merge 1 commit into
Open
Conversation
Author
|
@jjamroga I see this PR wasn't automatically assigned since there is no CODEOWNERS file. Is this something you usually review ? Thanks in advance and sorry for the tag if its not you. |
EItanya
force-pushed
the
main
branch
2 times, most recently
from
July 7, 2026 14:02
eec90e9 to
0e3b4ed
Compare
the-mentor
force-pushed
the
add-nodeselector
branch
3 times, most recently
from
July 9, 2026 14:50
f6f83ed to
4858ee9
Compare
Add a global `nodeSelector` value plus per-component overrides (ateApiServer, ateController, atenetRouter, dns, rustfs, atelet) so the substrate workloads can be pinned to specific nodes. Each component resolves its effective nodeSelector as `or .Values.<component>.nodeSelector .Values.nodeSelector`, so a non-empty component-level map wins and otherwise the global default applies. All defaults are empty, so rendered output is unchanged (render-manifests --check passes). valkey is intentionally excluded. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
the-mentor
force-pushed
the
add-nodeselector
branch
from
July 12, 2026 06:35
4858ee9 to
3c6f01c
Compare
Author
|
@EItanya Is this PR something you can help push to approval ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable
nodeSelectorso substrate workloads can be pinned to specific nodes:ate-api-server-deploymentate-controlleratenet-routerdns(atenet-dns)rustfsatelet(DaemonSet)Configuration
Two levels:
nodeSelectorinvalues.yamlapplies to all of the above.ateApiServer.nodeSelector,ateController.nodeSelector,atenetRouter.nodeSelector,dns.nodeSelector,rustfs.nodeSelector, andatelet.nodeSelectoreach override the global default for that component when set to a non-empty map.Each pod spec resolves its effective selector with
or .Values.<component>.nodeSelector .Values.nodeSelector— an empty map is falsy in Go templates, so a component value wins when present and the global applies otherwise.valkeyis intentionally left out.Verification
helm templatewith defaults renders nonodeSelector(backward compatible).helm templatewith global + per-component overrides renders correctly for all workloads, including the atelet DaemonSet.helm lintpasses.hack/render-manifests.sh --checkpasses — committed manifests are unchanged since defaults are empty.🤖 Generated with Claude Code