👷 ci: add lint, types and coverage gates to PR workflow - #671
Merged
Conversation
- tests.yml now runs lint, check:types, check:prettier and tests with coverage instead of only vitest run - Enforce coverage thresholds (63/56/60/64) as a ratchet floor, measured against current coverage after excluding auto-generated icon assets - New storybook-check.yml builds Storybook on PRs touching lib, .storybook or the package manifests, so a broken Storybook is caught before deploy
futjesus
force-pushed
the
ci/pr-checks-and-coverage
branch
from
July 27, 2026 14:52
9c8f505 to
1d5e16b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second PR of the audit series, stacked on #670 (its coverage excludes feed the threshold values here). Until now, PR CI ran only
vitest run— lint, type errors and formatting were caught only by the local (bypassable) husky hook.Changes
Lint,Type checkandPrettier checksteps, and switches the test step tonpm run test(vitest with coverage) — the exact mirror of the pre-commit hook, now enforced server-side. Theciscript was deliberately left untouched: the release workflow depends on its current semantics.npm run testand the pre-commit hook too.lib/**,.storybook/**or the package manifests. Today a broken Storybook build is only discovered at deploy time (post-publish). Note: not intended as a required check — path-filtered runs show as skipped.Testing
npx vitest run --coveragepasses with the new thresholds.npm run cigreen locally.