WIP: migrate deprecated datacenter field to location#2054
Open
buraksekili wants to merge 1 commit into
Open
Conversation
Signed-off-by: Burak Sekili <32663655+buraksekili@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Hetzner removed the
datacenterproperty from its Servers API in July 2026, so any MachineDeployment that still setscloudProviderSpec.datacentereither fails to provision or lands in Hetzner's default location. This PR migratesdatacentertolocationon admission by deriving the location from the datacenter name prefix (nbg1-dc3becomesnbg1), removes all calls to the removed datacenter endpoints, and keeps the field parseable through a deprecation window so existing specs do not break on strict unmarshal. Hard removal of the field is left for a later release.Which issue(s) this PR fixes:
Fixes #2053
What type of PR is this?
/kind bug
/kind deprecation
Special notes for your reviewer:
Numeric
datacentervalues are rejected instead of migrated because Hetzner datacenter IDs do not map to location IDs (datacenter 4 isfsn1-dc14while location 4 isash).Createderives the location itself for specs that bypass the webhook, so runtime placement stays correct even with the webhook disabled. hcloud-go is bumped from v2.13.1 to v2.44.0 with no other dependency churn and no call site changes. The newTestHetznerProvisioningE2EDatacenterMigrationruns in the existing hetzner presubmit because its name matches the job's-runfilter. Thedcmetrics label is gone; dashboards using it need updating.Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
Test issue: