Handles omitted webhooks array and unnests the webhook dialog dropdown button - #889
Handles omitted webhooks array and unnests the webhook dialog dropdown button#889seb-kw wants to merge 1 commit into
Conversation
…n button Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
| jiraIntegrations: Array<JiraIntegrationDTO>; | ||
|
|
||
| webhooks: Array<WebhookDTO>; | ||
| // omitted by the API when there are none |
There was a problem hiding this comment.
Where did you get that information from?
https://github.com/l3montree-dev/devguard/blob/main/dtos/project_dto.go#L80
There is no omitempty JSON tag assigned to the webhooks slice. It is true that we do not always return the same DTO for projects. But we need to understand what DTO we actually need and why we don't get it there. Maybe we are updating a project and returning the wrong DTO afterward, and the client sets it to its state, which is the real issue?
There was a problem hiding this comment.
I logged the data object that I get from backend and saw (first block in screenshot), that if I have no webhook configured at all the response does not contain a webhook entry with empty array... So I assumed that the backend drops if no content to send.
There was a problem hiding this comment.
But strange - as you stated for project, when I get it right the https://github.com/l3montree-dev/devguard/blob/main/dtos/org_dto.go#L116 org dto does not have an omitempty either...
2 participants
No description provided.