Filter fake components for statistics - #2832
Open
Hubtrick-Git wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates statistics queries to exclude non-component “fake” dependency IDs (e.g., ROOT) by restricting results to valid pURL-like dependency IDs (pkg:%), improving the accuracy of component-related statistics.
Changes:
- Add
dependency_id LIKE 'pkg:%'filtering to the “most used components in org” query. - Add
dependency_id LIKE 'pkg:%'filtering to the “top components across instance” query.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| COUNT(DISTINCT (cd.asset_id)) AS total_amount, | ||
| COALESCE(1.0 * COUNT(DISTINCT (cd.asset_id)) / NULLIF((SELECT COUNT(*) FROM assets), 0), 0) as relative_amount | ||
| FROM component_dependencies cd | ||
| WHERE cd.dependency_id LIKE 'pkg:%' -filter out non components like ROOT |
Comment on lines
388
to
392
| WHERE c.organization_id = ? | ||
| AND a.dependency_id LIKE 'pkg:%' --filter out non components like ROOT | ||
| GROUP BY a.dependency_id | ||
| ORDER BY total_amount DESC, a.dependency_id ASC | ||
| LIMIT ?;`, orgID, limit).Find(&components).Error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.