docs: fix nested agent guide loading and trim root AGENTS.md#7992
Conversation
Nested agent guides are discovered through a CLAUDE.md entry point. protos/, python/, and java/ already had one; rust/ and docs/src/format/ did not, so their AGENTS.md never loaded.
The list restates what `ls rust/` and each crate's Cargo.toml description already provide, and it had drifted out of sync with the workspace.
|
Important This PR touches the Lance format specification. Substantive changes to the format specification — the If this is a meaningful format change:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Architecture section was removed from ChangesGuidance consolidation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rust/AGENTS.mdanddocs/src/format/AGENTS.mdwere never reaching coding agents. Nested guides are discovered through aCLAUDE.mdentry point in the directory —protos/,python/, andjava/each have one, but those two directories did not. The Rust guide is the largest and most safety-relevant of the set, carrying thespawn_cpu()non-blocking contract, theRowAddr/RowIdtype separation, and the lance-encoding hot-path rules, so agents editingrust/had none of it in context.The root
AGENTS.mdalso carried a hand-maintained crate list that duplicates whatls rust/and each crate'sCargo.tomldescription already state, and it had drifted:arrow-scalar,arrow-stats,lance-derive,lance-index-core,lance-namespace-datafusion,lance-select, andlance-tokenizerwere all missing. A stale map is worse than no map, and every session that loads the file pays for it. The directory-guide pointer above the list is unchanged, so navigation is unaffected.The format vote reminder will fire on this PR because it adds a path under
docs/src/format/. That path is a symlink to the agent guide already in that directory; the format specification itself is untouched.