fix: terratest 1.x OutputContext migration - #61
Merged
Conversation
aarti-joshi-nttd
approved these changes
Aug 10, 2026
aarti-joshi-nttd
left a comment
aarti-joshi-nttd
left a comment
Contributor
There was a problem hiding this comment.
Good Things
- Correctly migrates three deprecated
terraform.Outputcalls toterraform.OutputContext, verified against terratest v1.0.1's actual signature. go 1.26.0directive matches the repo's.tool-versionspin, avoiding toolchain mismatch.- All CI checks pass, including Run Tests / Terraform Tests.
No blocking issues found.
Non-blocking suggestions
- Consider
t.Context()instead ofcontext.Background(), consistent with upstream terratest v1.0.1 examples. - Large transitive dependency bump bundled with a "minimal" fix — worth a note in the PR description.
rakesh-gorige-nttd
approved these changes
Aug 11, 2026
rakesh-gorige-nttd
left a comment
rakesh-gorige-nttd
left a comment
There was a problem hiding this comment.
PR Review: fix: terratest 1.x OutputContext migration
Author: ben-vaughan-nttd
What This PR Does Well
- Correctly migrates deprecated terratest
Output*(and related) calls to the terratest 1.x*ContextAPI. - Keeps changes focused in test code; no Terraform module or production logic touched.
- CI is fully green, including Run Tests / Terraform Tests, validating the dependency bump end-to-end.
Fixes Required
Blocking
No blocking issues found.
Non-Blocking
| # | File | Issue |
|---|---|---|
| 1 | go.mod |
go get -u ./... also bumps AWS SDK and transitive deps beyond terratest; consider scoping future bumps to terratest only. |
| 2 | test files | Optional: use t.Context() instead of repeated context.Background() on Go 1.26. |
Review — approved
Verified terratest 1.x migration in tests only. CI green. No blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal terratest 1.x fix for Dependabot PR #60.
terraform.Output*to*Contextin tests onlygo get -u ./...andgo mod tidymake checkandpre-commitlocally