Update Bug Fix - #898
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adjusts aegis update behavior so that when a project was generated from a commit newer than the CLI’s resolved target (e.g., a dev checkout ahead of the latest release tag), the command exits successfully instead of treating it as a blocked downgrade. It also updates several locale files to include new update-related messaging and improves translations for AI sentiment/agent-registry CLI strings in the project template locales.
Changes:
- Treat “project ahead of target (implicit CLI target)” as a clean no-op success, while keeping explicit downgrades blocked.
- Add CLI i18n keys for the new “ahead of target” messaging across all
aegis/i18n/locales/*.py. - Update template app locale translations for sentiment stats + agent registry strings across multiple languages.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cli/test_update_command.py | Adds coverage for implicit-ahead-of-target succeeding and explicit downgrades remaining blocked. |
| aegis/commands/update.py | Implements the new “ahead of target” success path when --to-version is not provided. |
| aegis/i18n/locales/en.py | Adds English strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/de.py | Adds German strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/es.py | Adds Spanish strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/fr.py | Adds French strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/ja.py | Adds Japanese strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/ko.py | Adds Korean strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/ru.py | Adds Russian strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/zh.py | Adds Simplified Chinese strings for update.ahead_of_target and its hint. |
| aegis/i18n/locales/zh_hant.py | Adds Traditional Chinese strings for update.ahead_of_target and its hint. |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/zh.py | Translates sentiment/agent-registry CLI strings in the generated project template (zh). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/zh_hant.py | Translates sentiment/agent-registry CLI strings in the generated project template (zh_hant). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/ru.py | Translates sentiment/agent-registry CLI strings in the generated project template (ru). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/ko.py | Translates sentiment/agent-registry CLI strings in the generated project template (ko). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/ja.py | Translates sentiment/agent-registry CLI strings in the generated project template (ja). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/fr.py | Translates sentiment/agent-registry CLI strings in the generated project template (fr). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/es.py | Translates sentiment/agent-registry CLI strings in the generated project template (es). |
| aegis/templates/copier-aegis-project/{{ project_slug }}/app/i18n/locales/de.py | Translates sentiment/agent-registry CLI strings in the generated project template (de). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.