fix(review-r3): engine hardening + crash-resume seams#514
Merged
Conversation
This was referenced Jul 23, 2026
Merged
Merged
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 10:58
00ea1f0 to
ad7f469
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 11:05
c971da1 to
8ad0c0d
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 11:05
ad7f469 to
2b021b6
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:29
8ad0c0d to
6e264b3
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:29
2b021b6 to
1319978
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:30
6e264b3 to
19ff4c5
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:30
1319978 to
038b756
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:31
19ff4c5 to
af5addc
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:31
038b756 to
eb473bc
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:32
af5addc to
11c2481
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:32
eb473bc to
e6f4d32
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:32
11c2481 to
927adc3
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:32
e6f4d32 to
08d631d
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:33
927adc3 to
ed05893
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:33
08d631d to
9d1de7e
Compare
leeovery
force-pushed
the
feat/batch-review-round-2
branch
from
July 23, 2026 12:34
ed05893 to
9e13a3a
Compare
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:34
9d1de7e to
e56f7ca
Compare
Engine: parsePath refuses empty segments (aliased the project manifest under the wrong lock); commit refuses an empty work-unit name (swept all of .workflows); workunit create refuses reusing a name across work types; phaseStatus filters all non-live statuses order-independently; a topic whose every attempted phase is cancelled is lifecycle-cancelled (was fresh with a dead-end action); cancel stashes the map item's order and reactivate restores it; promoted items are terminal for start/complete/ supersede; resume-gate review coverage counts distinct task ids. Prose crash-resume seams: task-loop heals completed_tasks from plan marks; verifier pushes dedupe against a prior read; actions-loop resumes an in-flight staging file instead of re-dispatching; author-tasks skips tasks already in task_map (no external duplicates); analysis-loop resumes an unsynthesised cycle without re-recording; spec extraction re-reads before logging a pending source; pivot-to-epic declares its continuation_menu parameter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
leeovery
force-pushed
the
feat/batch-review-round-3
branch
from
July 23, 2026 12:35
e56f7ca to
984f4d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parsePath(empty dotpath aliased the project manifest under the work-unit lock), empty work-unit guard oncommit, work-type-mismatch refusal onworkunit createreuse, order-independent non-live filtering inphaseStatus, all-attempted-phases-cancelled topics now render as cancelled (wasfreshwith a dead-end next action), cancel/reactivate round-trips the map item'sorder, promoted items are terminal for start/complete/supersede, review resume-gate counts distinct reviewed ids.pivot-to-epicparameter declaration.Test plan
npm test— 1571 passnpm run test:cli,npm run test:migrations,npm run typecheck— green🤖 Generated with Claude Code
Stack