Closes #1464: Add support for libgit2's custom_headers#1465
Merged
Conversation
jdavid
requested changes
Jun 25, 2026
jdavid
left a comment
Member
There was a problem hiding this comment.
A full test will be difficult, maybe we can do something simple, AI suggested this...
Test that the headers are correctly copied into the C structs, similar to test_push_options in test/test_remote.py. Example:
def test_custom_headers(origin, clone, remote):
class MyCallbacks(pygit2.RemoteCallbacks):
def custom_headers(self):
return ['Authorization: Bearer token', 'X-Other: foo']
callbacks = MyCallbacks()
remote.push(['refs/heads/master'], callbacks)
assert callbacks.push_options.custom_headers.count == 2 A corresponding fetch/connect test would also be valuable.
f2f722f to
1f24b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback welcome of course, and also this may need more work, because I do not know how to write an automated test for this. An automated test rather depends on having a remote that requires a specific header and fails without it (my particular use case), which isn't really amenable to an automated test. I would love thoughts on approaches I could take. Otherwise, the existing pytest suite, mypy, ruff, and subtests pass.
Manual test: