Skip to content

libvmi: Change to vmi_get_max_physical_address#91

Merged
Wenzel merged 1 commit into
libvmi:masterfrom
netanelc305:bugfix/wrong_function_name
Aug 9, 2024
Merged

libvmi: Change to vmi_get_max_physical_address#91
Wenzel merged 1 commit into
libvmi:masterfrom
netanelc305:bugfix/wrong_function_name

Conversation

@netanelc305

Copy link
Copy Markdown

No description provided.

@Wenzel

Wenzel commented Aug 8, 2024

Copy link
Copy Markdown
Member

Thanks for this PR !
Although i don't understand why the CI passes, since i'm pinning a specific commit for libvmi ?

When did the API name changed ?

check the github actions libvmi setup:
"e7074407fc3b98db1aa73f918b3720bd4438734b"

@netanelc305

Copy link
Copy Markdown
Author

Not sure when.
I just tried to use the previous function and there way a mismatch and got this error AttributeError: cffi library '_libvmi' has no function, constant or global variable named 'vmi_get_max_physical_memory_address'. Did you mean: 'vmi_get_max_physical_address'? .

so i checked the name and saw it is diffent, after changing everything works fine :)

@tklengyel

Copy link
Copy Markdown
Contributor

LGTM

@Wenzel Wenzel merged commit ae859f9 into libvmi:master Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants