fix(test): give the contended restore its real production wait budget

[lidge-jun]

Summary

Restores dev to green. The composed-acceptance "Restore truth" case failed on the macOS shard of the post-merge dev run (31105071651) after #1106 landed.

It is a watchdog-margin bug in the test, not a product regression. The case holds state_5.sqlite with BEGIN IMMEDIATE and then runs a real ocx restore --json child, which deliberately waits out production's retry budget before it may report busy: a 5 s SQLite busy timeout per attempt, two attempts (HISTORY_RETRY_ATTEMPTS), plus HISTORY_RETRY_DELAY_MS between them — roughly 11 s of intentional waiting. The CLI watchdog was set to 15 s, leaving under 4 s of headroom, which a loaded CI runner consumed. The watchdog now gets 30 s; the case's own 45 s test timeout still bounds it, and no production timing changed.

Verification

• bun test ./tests/codex-composed-acceptance.test.ts — 6 pass / 0 fail (14.94 s locally; the contended case alone accounts for ~11 s of that by design).
• bun x tsc --noEmit — clean.
• Single-file change, tests only; no src/ diff.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed (not applicable — test-only timing margin).
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (no auth, credential, or workflow surface touched).

Summary by CodeRabbit

• Tests
  • Increased the timeout for the restore contention acceptance test to accommodate production retry delays.
  • Kept the test within its overall execution limit.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f84b7748-0417-4f0b-8825-4cd828aeb583

📥 Commits

Reviewing files that changed from the base of the PR and between 43a1fdc and eb0923e.

📒 Files selected for processing (1)

• tests/codex-composed-acceptance.test.ts

---

📝 Walkthrough

Walkthrough

The restore contention acceptance test increases the blocked restore --json watchdog timeout from 15 to 30 seconds. Comments document the expected SQLite retry duration and added headroom. The overall test limit remains 45 seconds.

Changes

Restore contention acceptance test

Layer / File(s)	Summary
Restore retry timeout tests/codex-composed-acceptance.test.ts:480-486	The contended restore --json invocation now allows 30 seconds for SQLite retry delays instead of 15 seconds. Comments document the timeout rationale.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• lidge-jun/opencodex#614: Adjusts test timeouts for platform-dependent delays.
• lidge-jun/opencodex#732: Adjusts test timeout budgets in a different test scope.

Suggested labels: chore

Suggested reviewers: wibias, ingwannu

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the test timeout change for the contended restore and matches the pull request objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/260806-restore-watchdog-margin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}