Make review reminders opt-in#10
Open
joostjager wants to merge 1 commit into
Open
Conversation
Add an ENABLE_REVIEW_REMINDERS configuration flag that defaults to disabled while preserving automatic reviewer assignment. The scheduler now skips stale-review reminder comments unless the flag is explicitly set to true.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Author
|
Oops, duplicate of #9 I guess we have the choice now between removal or disabling. |
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ENABLE_REVIEW_REMINDERS configuration flag that defaults to disabled while preserving automatic reviewer assignment. The scheduler now skips stale-review reminder comments unless the flag is explicitly set to true.
This addresses lightningdevkit/rust-lightning#4735. The recurring public reminder comments have become noisy relative to their value: in the issue's March 21, 2026 through June 21, 2026 snapshot, ldk-reviews-bot posted 550 reminder comments, which were 34.0% of all PR issue comments and slightly outnumbered human PR issue comments. Those reminders generated 710 reviewer mentions, often repeated on the same PRs, while most repeated reminders did not receive a tagged-reviewer response before the bot posted again.
Disabling reminders by default removes that PR timeline noise while keeping the useful parts of the bot intact. The bot can still assign reviewers, track review state, and ask about second reviewers, but deployments now have to opt in explicitly before posting recurring stale-review nudges.