Async payments: apply review fixes missed from #314#316
Merged
Conversation
- Revert blog author to canonical "Valentine Wallace" so the post links the existing author archive instead of an orphan slug - Correct Event::PersistStaticInvoice fields (invoice_request_path / invoice_persisted_path) in the guide - Add a beta callout to the blog post; note the unmerged sender-side flow and LDK-to-LDK-only status - Title-case guide subsection headings and the blog "Integrating It Into Your App" heading to match repo convention (anchors unchanged) - Standardize on "static invoice server" (unhyphenated) - Replace unexplained "secret B" with "the release secret" - Lightbox: move focus into the dialog on open and restore it on close; save/restore body overflow instead of clobbering it; trim the alt text Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The review-agent commit `49ad33bb` ("Address code review: docs accuracy, headings, and lightbox a11y") was committed locally but never pushed, so it wasn't part of PR #314's squash merge. As a result
main— and the live site — are missing these review changes. This PR cherry-picks that commit cleanly ontomain.What's included
Blog post (
async-payments-receiving-while-offline.md)::: warning Betacallout (async payments are in beta, LDK-to-LDK only, sender-side flow not fully merged)2026-06-23→2026-06-26and authors (Matt Corallo → Valentine Wallace + Conor Okus)Guide (
async-payments.md)invoice_request_path/invoice_persisted_pathaccuracy fixesDiagram (
AsyncPaymentsSequenceDiagram.vue)Verification
npm run build:vitepresspassesmainis exactly the 3 review files (48 insertions, 24 deletions)🤖 Generated with Claude Code