Skip to content

chore: Sync account schemas #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lightspark-copybara wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Sync account schemas #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions openapi/components/schemas/common/GtqAccountInfoBase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ required:
- accountType
- accountNumber
- bankAccountType
- bankName

@greptile-apps greptile-apps Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Breaking change — bankName is now required for GTQ and JMD accounts

Adding bankName to the required array is a backward-incompatible change for any existing API consumers that currently submit GTQ or JMD account payloads without this field. Callers who have already stored or cached payloads without bankName will start receiving validation errors. The same applies to JmdAccountInfoBase.yaml. Please confirm this is intentional and that downstream VASP adapters / existing integrations have been updated (or will be updated atomically) before this schema is deployed.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/common/GtqAccountInfoBase.yaml
Line: 6

Comment:
**Breaking change — `bankName` is now required for GTQ and JMD accounts**

Adding `bankName` to the `required` array is a backward-incompatible change for any existing API consumers that currently submit GTQ or JMD account payloads without this field. Callers who have already stored or cached payloads without `bankName` will start receiving validation errors. The same applies to `JmdAccountInfoBase.yaml`. Please confirm this is intentional and that downstream VASP adapters / existing integrations have been updated (or will be updated atomically) before this schema is deployed.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

properties:
accountType:
type: string
Expand All @@ -19,7 +20,13 @@ properties:
enum:
- CHECKING
- SAVINGS
bankName:
type: string
description: The name of the bank
minLength: 1
maxLength: 255
example:
accountType: GTQ_ACCOUNT
accountNumber: '1234567890'
bankAccountType: CHECKING
bankName: Example Bank
7 changes: 7 additions & 0 deletions openapi/components/schemas/common/JmdAccountInfoBase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ required:
- accountNumber
- branchCode
- bankAccountType
- bankName
properties:
accountType:
type: string
Expand All @@ -26,8 +27,14 @@ properties:
enum:
- CHECKING
- SAVINGS
bankName:
type: string
description: The name of the bank
minLength: 1
maxLength: 255
example:
accountType: JMD_ACCOUNT
accountNumber: '1234567890'
branchCode: '11111'
bankAccountType: CHECKING
bankName: Example Bank
Loading