Add missing OutgoingTransactionFailureReason enum values#628
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
Add missing OutgoingTransactionFailureReason enum values#628ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
Add EXECUTION_FAILED_POST_DEBIT, SETTLEMENT_FAILED, TIMEOUT, and MANUAL_REFUND to the OutgoingTransactionFailureReason enum so the public Grid API can represent the full set of failure reasons the backend emits. Without them, sparkcore's mapping from the internal UmaaasSendOperationFailureReason to this public enum (by name) throws a KeyError and reports an empty failure reason for settlement/timeout/manual-refund/post-debit failures.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four missing values to the public
OutgoingTransactionFailureReasonenum so the Grid API can represent the full set of failure reasons the backend actually emits:EXECUTION_FAILED_POST_DEBITSETTLEMENT_FAILEDTIMEOUTMANUAL_REFUNDWhy
sparkcore maps its internal
UmaaasSendOperationFailureReasononto this public enum by name (sparkcore/grid/objects/transaction.py::_get_outgoing_transaction_failure_reason). The internal enum has these four members but the public enum didn't, so the mapping threw a (caught)KeyError, logged"Key does not exist in GridOutgoingTransactionFailureReason", and returnedNone— meaning the API reported an empty failure reason for settlement / timeout / manual-refund / post-debit failures, plus noisy ERROR logs on every render of such a transaction.Surfaced while debugging the embedded-USDB onramp failures (those failed send-operations carry
SETTLEMENT_FAILED).What changed
openapi/components/schemas/transactions/OutgoingTransactionFailureReason.yaml— source enum (the only hand edit)openapi.yaml+mintlify/openapi.yaml— regenerated viamake build(redocly bundle)Notes / decisions
LSP_OPERATIONAL_FAILUREintentionally NOT added — sparkcore deliberately maps it toQUOTE_EXECUTION_FAILED(internal-only distinction for LSP-liquidity alerting), so it should never reach the public enum.EXECUTION_FAILED_POST_DEBIT: it's documented internally as an internal-only distinction (lets the compensation scanner safely credit). I chose to expose it for completeness so the mapping needs no special-case, but it could instead be mapped toQUOTE_EXECUTION_FAILEDin sparkcore likeLSP_OPERATIONAL_FAILURE. Easy to flip — happy to if you'd prefer to keep it internal.Follow-up (separate PR, needed for the runtime fix)
This is the canonical spec change. webdev's vendored generated
grid-apipython package (webdev/grid-api, consumed by sparkcore as a path dep) must be regenerated from this spec viagrid-api/update_schema.sh+ apackageVersionbump +sparkcore/uv.lockupdate for sparkcore to actually pick up the new members. That regen needs the Java/Maven/openapi-generator toolchain and is a separate webdev PR — until it lands, sparkcore stillKeyErrors.Test plan
make lint-openapi(redocly + spectral,--fail-severity=error) passes — no new findings🤖 cryptic-tempest(#1) | Feedback