Skip to content

fix(grid-visualizer): sync GTQ and JMD account fields with OpenAPI schema#634

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260630
Open

fix(grid-visualizer): sync GTQ and JMD account fields with OpenAPI schema#634
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260630

Conversation

@claude

@claude claude Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Grid Visualizer: Updated account-types.ts to match recent OpenAPI schema changes:
    • GTQ_ACCOUNT: Replaced phoneNumber with bankAccountType and bankName (now required per commit 95ded8a)
    • JMD_ACCOUNT: Added bankName field (now required per commit 95ded8a)

Context

This PR syncs the Grid Visualizer with the OpenAPI schema changes from the last 24 hours:

  • 88880915 feat(openapi): add rail + settlement-timing fields to OutgoingTransaction
  • c9d7766a [grid] add customer phoneNumber API surface
  • 95ded8a8 Add bankName as a required field to GTQ and JMD account types
  • 8aa0022b docs(openapi): correct exchangeRate example to match documented basis

No changes needed for:

  • Webhooks documentation: Already includes paymentRail, railSelectionMode, expectedSettlementAt, settlementTimelineSeconds fields
  • Customer documentation: phoneNumber is an optional field, no doc updates required
  • Kotlin sample app: Does not handle GTQ/JMD accounts (only common account types as examples)

Test plan

  • Verify Grid Visualizer builds successfully
  • Check that GTQ and JMD account examples render correctly with new fields

🤖 Generated with Claude Code

…hema

Update account-types.ts to match recent OpenAPI schema changes:
- GTQ_ACCOUNT: Replace phoneNumber with bankAccountType and bankName (now required)
- JMD_ACCOUNT: Add bankName (now required)

These changes align with commits 95ded8a which added bankName as a
required field for GTQ and JMD account types.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude claude Bot requested review from pengying and shreyav June 30, 2026 09:14
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Jun 30, 2026 9:15am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
grid-wallet-demo Ignored Ignored Jun 30, 2026 9:15am

Request Review

@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR syncs account-types.ts in the Grid Visualizer with the OpenAPI schema changes from commit 95ded8a8, keeping the visualizer's example payloads accurate for developers.

  • GTQ_ACCOUNT: removes the now-absent phoneNumber field and adds bankAccountType (enum: CHECKING/SAVINGS) and bankName as required fields, matching GtqAccountInfoBase.yaml exactly.
  • JMD_ACCOUNT: adds bankName as a required field, matching JmdAccountInfoBase.yaml exactly.

Confidence Score: 5/5

Safe to merge — the changes are a straightforward data sync with no logic, no side effects, and exact parity with the OpenAPI schema.

Both GTQ_ACCOUNT and JMD_ACCOUNT field lists now match their respective OpenAPI schema files character-for-character. The removed phoneNumber field on GTQ is absent from the current schema, and both newly added fields use the correct enum values and example strings already present in the YAML definitions.

No files require special attention.

Important Files Changed

Filename Overview
components/grid-visualizer/src/data/account-types.ts GTQ_ACCOUNT drops phoneNumber and gains bankAccountType+bankName; JMD_ACCOUNT gains bankName — both match the OpenAPI schema exactly.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant OAS as OpenAPI Schema
    participant ATS as account-types.ts
    participant GV as Grid Visualizer UI

    Note over OAS: commit 95ded8a8<br/>GTQ: +bankAccountType, +bankName, -phoneNumber<br/>JMD: +bankName (required)

    OAS->>ATS: Sync GTQ_ACCOUNT fields
    Note over ATS: accountNumber<br/>bankAccountType (CHECKING|SAVINGS)<br/>bankName

    OAS->>ATS: Sync JMD_ACCOUNT fields
    Note over ATS: accountNumber<br/>branchCode<br/>bankAccountType (CHECKING|SAVINGS)<br/>bankName added

    ATS->>GV: Render updated example payloads
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant OAS as OpenAPI Schema
    participant ATS as account-types.ts
    participant GV as Grid Visualizer UI

    Note over OAS: commit 95ded8a8<br/>GTQ: +bankAccountType, +bankName, -phoneNumber<br/>JMD: +bankName (required)

    OAS->>ATS: Sync GTQ_ACCOUNT fields
    Note over ATS: accountNumber<br/>bankAccountType (CHECKING|SAVINGS)<br/>bankName

    OAS->>ATS: Sync JMD_ACCOUNT fields
    Note over ATS: accountNumber<br/>branchCode<br/>bankAccountType (CHECKING|SAVINGS)<br/>bankName added

    ATS->>GV: Render updated example payloads
Loading

Reviews (1): Last reviewed commit: "fix(grid-visualizer): sync GTQ and JMD a..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants