docs(openapi): add title to CardTransaction so docs render a named chip#638
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
docs(openapi): add title to CardTransaction so docs render a named chip#638ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✱ Stainless preview builds for gridThis PR will update the cli go kotlin php python typescript ⏳ grid-csharp studio⏳ grid-typescript studio⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
benwgold
added a commit
that referenced
this pull request
Jul 2, 2026
…ip (#639) ## Summary The Grid API docs schema viewer (e.g. [get-transaction-by-id](https://docs.lightspark.com/api-reference/transactions/get-transaction-by-id)) rendered the third `TransactionOneOf` variant as a generic **Option 3** chip. `IncomingTransaction` and `OutgoingTransaction` both declare a `title`, which Mintlify uses for the chip label; `CardTransaction` (added in #622) did not, so the renderer fell back to "Option 3". This adds `title: Card Transaction` to the `CardTransaction` schema and regenerates the bundled specs (`openapi.yaml`, `mintlify/openapi.yaml`) via `npm run build:openapi`. ## Test plan - `npm run lint:openapi` passes (Redocly bundle + lint, Spectral lint — exit 0, only pre-existing warnings) - Diff is exactly the one source line plus the same line in the two generated bundles Requested by Ben in Slack (thread linked below). Slack thread: https://lightsparkgroup.slack.com/archives/C0A28TVUZ4Z/p1783024275813329 --- 🤖 [blazing-photon](https://zeus.dev.dev.sparkinfra.net/#/arc?id=blazing-photon)[(#1)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=blazing-photon) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) Original PR: #638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Grid API docs schema viewer (e.g. get-transaction-by-id) rendered the third
TransactionOneOfvariant as a generic Option 3 chip.IncomingTransactionandOutgoingTransactionboth declare atitle, which Mintlify uses for the chip label;CardTransaction(added in #622) did not, so the renderer fell back to "Option 3".This adds
title: Card Transactionto theCardTransactionschema and regenerates the bundled specs (openapi.yaml,mintlify/openapi.yaml) vianpm run build:openapi.Test plan
npm run lint:openapipasses (Redocly bundle + lint, Spectral lint — exit 0, only pre-existing warnings)Requested by Ben in Slack (thread linked below).
Slack thread: https://lightsparkgroup.slack.com/archives/C0A28TVUZ4Z/p1783024275813329
🤖 blazing-photon(#1) | Feedback