refactor: centralize category name localization to C++ model - #787
refactor: centralize category name localization to C++ model#787wjyrich wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f50f5fb to
ff79779
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Move the category name mapping logic from multiple QML files into the C+ + ItemArrangementProxyModel to reduce code duplication and fix potential string localization issues. This ensures consistent category display names across all views. Log: Optimize category name processing logic Influence: 1. Verify that app category names display correctly in folder grid and list views 2. Test category names in windowed mode (Alphabetical and Category sorting) 3. Check that folder popups show correct category names 4. Verify no untranslated "internal/category/" strings appear in the UI 5. Ensure localized strings still support proper translation 6. Test the dock launcher applet's folder interactions refactor: 将分类名称本地化逻辑集中到 C++ 模型中 将多个 QML 文件中的分类名称映射逻辑移到 C++ 的 ItemArrangementProxyModel 中，减少代码重复并修复潜在的字符串本地化问题。这确保了所有视图中分类显示 名称的一致性。 Log: 优化分类名称处理逻辑 Influence: 1. 验证文件夹网格和列表视图中应用分类名称显示正确 2. 测试窗口模式下（按字母排序和按分类排序）的分类名称 3. 检查文件夹弹出窗口显示正确的分类名称 4. 确保界面中不会出现未翻译的 "internal/category/" 字符串 5. 确认本地化字符串仍支持正常翻译 6. 测试 dock 启动器控件的文件夹交互功能 PMS: TASK-392671
ff79779 to
94c56a9
Compare
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // 代码质量优秀，无需额外修复 |
BLumia
left a comment
BLumia
left a comment
There was a problem hiding this comment.
与此 PR 无直接相关性：dde-shell 之前有预留文件夹的支持并且应该也预留了配置迁移的支持，之前的计划是 dde-launchpad 接 dde-shell 的 dde-apps 组件，两边共用同一套模型，数据也维持一份（不需要两边同步）。可以回顾下那个方案？（见 dde-shell 的 appgroup.{cpp,h}，以及关联的代码）
3 participants
Move the category name mapping logic from multiple QML files into the C+
Log: Optimize category name processing logic
Influence:
refactor: 将分类名称本地化逻辑集中到 C++ 模型中
将多个 QML 文件中的分类名称映射逻辑移到 C++ 的 ItemArrangementProxyModel 中，减少代码重复并修复潜在的字符串本地化问题。这确保了所有视图中分类显示
名称的一致性。
Log: 优化分类名称处理逻辑
Influence:
PMS: TASK-392671