test: address peer-review findings across all modules#53
Conversation
flexiondotorg
commented
Jul 5, 2026
flexiondotorg
commented
- cmd/jive-encoder: add tests for Hugo PostEncode and CollectMetadata; propagate frontmatter and missing audio errors to exit code; document date handling; standardise helpers
- internal/encoder: standardise Close() error handling; extract setDictOptions helper; add format assertions; relocate test fixtures to temp directory
- internal/artwork: replace draw.Over with draw.Src; add GIF test; tighten output bounds; document design choice
- internal/cli: deduplicate colour literals; add warning colour; add help tests for positional args; capture write errors in help printer
- internal/ui: fix double frame-tick loop; add table tests for speed and format helpers; align elapsed time to live base
- .github/workflows/builder.yml: pin govulncheck to v1.0.4; enable CGO_ENABLED=1 in build, test, and coverage jobs
- cmd/jive-encoder: add tests for Hugo PostEncode and CollectMetadata; propagate frontmatter and missing audio errors to exit code; document date handling; standardise helpers - internal/encoder: standardise Close() error handling; extract setDictOptions helper; add format assertions; relocate test fixtures to temp directory - internal/artwork: replace draw.Over with draw.Src; add GIF test; tighten output bounds; document design choice - internal/cli: deduplicate colour literals; add warning colour; add help tests for positional args; capture write errors in help printer - internal/ui: fix double frame-tick loop; add table tests for speed and format helpers; align elapsed time to live base - .github/workflows/builder.yml: pin govulncheck to v1.0.4; enable CGO_ENABLED=1 in build, test, and coverage jobs Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 19 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Contains changes to CI config (CGO_ENABLED), artwork draw operator, and error propagation in workflows; these modify build and core logic behavior, requiring human review.
Re-trigger cubic
- Update README.md and .tailor.yml: emoji 🪩 → 🗜️ - Rebrand AppTitle constant in internal/cli/styles.go - Remove disco/disco ball references from code comments - Update golden test in help_golden_test.go Signed-off-by: Martin Wimpress <code@wimpress.io>
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 7 files (changes from recent commits).
Auto-approved: Adds tests, fixes bugs, refactors helpers, and updates CI config. Low-risk changes addressing review findings.
Re-trigger cubic
- Fix filter-graph endpoint allocator mismatch; use FFmpeg allocator with nil-check - Implement deferred partial-file cleanup on encode failure - Rewrite TestFormatFlag to parse real CLI struct - Refactor run() to testable dispatch() function - Add test coverage for refactored dispatch() workflow Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Auto-approved: Dominant changes are testing improvements, CI workflow pinning, and cosmetic updates (emoji, color refactoring). Business logic changes are limited to non-critical error propagation and documentation comments. Risk is low.
Re-trigger cubic
- Encoder: replace fmt.Errorf with errors.New, add nil-deref guard, tighten test - CLI: document HelpOptions and Print* contract; add SetOutput hook; skip hidden flags - UI: document callback contract; rename progress to avoid shadow - UI: document elapsed-time freeze; gate animation for non-interactive mode - Artwork: switch resampler to CatmullRom; document EXIF and colour-profile limits Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 11 files (changes from recent commits).
Requires human review: CI workflow changes, core artwork scaler logic, and exit code modifications require human review.
Re-trigger cubic
1 participant
