refactor: fix peer review findings across audio, encoder, UI, and too…#62
Conversation
…ling - RMS window: clarify that analysis runs over overlapping FFT window, not per-frame audio - Geometry guards: compile-time assertions for FFTSize/NumBars and frame buffer alignment - YUV export: export ConvertRGBAToYUV; bench now calls it instead of maintaining a copy - hwframe reuse: move hwframe from per-frame alloc/free to a reusable field - FPS division: guard against zero divisor in summary view - Preview cache: relocate cache write from View() path to Update() handler - CLI scope: move package-level CLI variable into main() scope - CGO + tooling: explicit CGO_ENABLED=1 in CI; golangci-lint pinned to action and flake comment Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 16 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Refactoring and fixes across audio, encoder, UI, and tooling: clarify RMS comment, add compile-time guards, improve error handling, move CLI scope, reuse hwframe, relocate preview cache, and bump CI config. All changes are low-impact cleanups and guards.
Re-trigger cubic
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Auto-approved: CI config and cosmetic updates; refactors for CLI scope, preview cache, and exported converter; compile-time guards and bug fixes (zero-division, duration).
Re-trigger cubic
Signed-off-by: Martin Wimpress <code@wimpress.io>
- Clamp dB display to -120 floor for silent input (fixes -Inf ㏈) - Read Kong flag defaults directly, stop string-matching sentinels - Consolidate colour palette to single Fire vocabulary - Remove inert hwEncoderOptionsSoftware enum constant - Inline dead renderLiveSpectrumBlock and renderLivePreviewBlock passthroughs - Remove unused RenderProgress.Sensitivity field - Add thumbnail text placement regression test - Document GlobalRMS as mean of per-window values, not signal RMS - Consolidate Encoder.Close() to single deferred close with reachedEnd flag Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 11 files (changes from recent commits).
Requires human review: The PR includes a refactor across audio, encoder, UI, and tooling with changes to core logic (encoder close strategy, hardware frame reuse, FPS division guard, metadata validation, FFT compile-time assertions). These affect critical paths and require human review.
Re-trigger cubic
1 participant
…ling