Move cachpath consensus to be calculated at init time - #194
Merged
Conversation
Collaborator
|
Code looks good, works 3x on rzadams. Will go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #187
Cachepath consensus was being triggered by a message from the FE. This was the likely cause of race conditions as the consensus algorithm collided with both the client connections and other communications happening.
This comment removes the trigger for consensus being a message initiated by the FE. Instead consensus is triggered during server initialization, before clients are allowed to connect. Because of this we were able to remove the timeout/retry code from clients that triggers if they connect before consensus is reached.