Skip to content

[WRONG BRANCH] fix(command-code): guard model alias lookups - #12

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-command-code-effort-lookup-vulnerability
Closed

[WRONG BRANCH] fix(command-code): guard model alias lookups#12
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-command-code-effort-lookup-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A robustness regression used a plain object lookup for canonical Command Code model aliases so prototype-property names like __proto__ could resolve to inherited non-string values and cause TypeError during reasoning-effort lookup.

Description

  • Add a canonicalization helper canonicalCommandCodeModelId(modelId) that uses Object.hasOwn to resolve aliases and treat prototype names literally.
  • Use the canonicalization helper for both the reasoning-effort lookup and the outbound params.model field so legacy aliases still work.
  • Harden commandCodeReasoningEfforts / profile access with Object.hasOwn guards to avoid reading inherited prototype properties as effort arrays.
  • Add a regression test treats prototype property names as literal model ids covering __proto__, constructor, and toString to ensure those IDs are forwarded literally and do not produce a reasoning_effort value.

Testing

  • Ran bun run test tests/command-code-provider.test.ts and the focused Command Code suite passed (23 tests passed).
  • Ran bun run typecheck and bun run privacy:scan, both completed successfully.
  • Ran the full bun run test where the Command Code tests passed but the full suite hit a pre-existing, unrelated timeout in tests/codex-catalog-sync-hardening.test.ts (that failure is not caused by these changes).

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f6694587-ee7d-41f5-ae49-2faf1ba3954b

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 97a62c9.

📒 Files selected for processing (3)
  • src/adapters/command-code.ts
  • src/providers/command-code-efforts.ts
  • tests/command-code-provider.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(command-code): guard model alias lookups [WRONG BRANCH] fix(command-code): guard model alias lookups Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 05:34
@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026

luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner Author

Closing this wrong-base fork PR after validating a corrected dev-based implementation with own-property coverage on both supported Bun runtimes.

@luvs01 luvs01 closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant