[WRONG BRANCH] fix(command-code): guard model alias lookups - #12
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Closing this wrong-base fork PR after validating a corrected |
Motivation
__proto__could resolve to inherited non-string values and causeTypeErrorduring reasoning-effort lookup.Description
canonicalCommandCodeModelId(modelId)that usesObject.hasOwnto resolve aliases and treat prototype names literally.params.modelfield so legacy aliases still work.commandCodeReasoningEfforts/ profile access withObject.hasOwnguards to avoid reading inherited prototype properties as effort arrays.treats prototype property names as literal model idscovering__proto__,constructor, andtoStringto ensure those IDs are forwarded literally and do not produce areasoning_effortvalue.Testing
bun run test tests/command-code-provider.test.tsand the focused Command Code suite passed (23 tests passed).bun run typecheckandbun run privacy:scan, both completed successfully.bun run testwhere the Command Code tests passed but the full suite hit a pre-existing, unrelated timeout intests/codex-catalog-sync-hardening.test.ts(that failure is not caused by these changes).