Skip to content

[WRONG BRANCH] fix(oauth): clear transient Anthropic refresh intent - #161

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-sticky-reauth-on-transient-errors
Draft

[WRONG BRANCH] fix(oauth): clear transient Anthropic refresh intent#161
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-sticky-reauth-on-transient-errors

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A durable Anthropic refresh-intent sidecar was left behind when def.refresh() threw non-terminal errors (timeouts/5xx), causing a leftover intent to be treated as a consumed rotating-token and marking the account needsReauth on the next attempt.

Description

  • Clear the generation-bound durable intent on non-terminal refresh failures so transient Anthropic errors do not leave a sticky sidecar; the catch now clears the intent and rethrows for non-terminal errors.
  • Preserve the intent for true replay-protection errors by continuing to rethrow OAuthMutationBusyError and OAuthTokenRefreshStaleError without clearing the intent.
  • Expand the Anthropic refresh regression test to assert the intent is removed after a transient failure, to retry the same account successfully, and to ensure needsReauth remains unset.

Testing

  • Ran the focused test: ./node_modules/bun/bin/bun.exe test --isolate tests/oauth-refresh.test.ts, which passed (29 tests, 0 failures).
  • Ran typecheck with bun x tsc --noEmit, which succeeded.
  • Ran privacy scan with bun run privacy:scan, which succeeded.
  • Ran the full test suite via bun run test during verification and observed unrelated failures in other suites (not related to the OAuth fix); the focused Anthropic refresh tests passed successfully.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 124d5eb6-21c4-4301-847d-e0b2b6b59822

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 689b5dc.

📒 Files selected for processing (2)
  • src/oauth/index.ts
  • tests/oauth-refresh.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(oauth): clear transient Anthropic refresh intent [WRONG BRANCH] fix(oauth): clear transient Anthropic refresh intent Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant