Skip to content

[WRONG BRANCH] fix(claude): avoid leaking main ChatGPT credential to non-canonical openai-responses providers - #162

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-token-leak-vulnerability
Closed

[WRONG BRANCH] fix(claude): avoid leaking main ChatGPT credential to non-canonical openai-responses providers#162
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-token-leak-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A replay path for Claude messages unconditionally injected the operator's stored main ChatGPT bearer into internal /v1/responses replays whenever the selected route used the openai-responses adapter, which could expose the main token to custom forward-mode providers.
  • The main ChatGPT credential must only be forwarded to the canonical ChatGPT forward destination (the built-in ChatGPT Codex backend), not to arbitrary openai-responses gateways configured by users.

Description

  • Added a check using isCanonicalOpenAiForwardProvider and a local allowMainAccountEnrichment flag so main-account enrichment is only enabled for the canonical ChatGPT forward provider; other openai-responses forward providers are excluded. (changed src/server/claude-messages.ts).
  • Gated the call that reads/injects the main Codex/ChatGPT token behind allowMainAccountEnrichment && tryClaimNativeMainProfileForTurn(...), so the credential is not attached to custom forward-mode openai-responses routes. (changed src/server/claude-messages.ts).
  • Added a regression test that configures a custom openai-responses provider with authMode: "forward" and a stored auth.json, and verifies that the upstream does not receive Authorization or chatgpt-account-id. (new test in tests/claude-messages-endpoint.test.ts).

Testing

  • Ran bun run typecheck and bun run privacy:scan, both completed successfully.
  • Added and executed the focused regression tests/claude-messages-endpoint.test.ts, which passed and verifies the credential is not leaked to a custom forward provider.
  • Ran the test suite with bun run test; the focused Claude endpoint tests (including the new regression) passed; there were earlier environment-specific CLI expectations and Bun-version artifacts during an isolated run, but the repository's standard test run exercised the Claude endpoints and confirmed the fix.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ea5d1d85-9ccd-41f4-bcaa-5cb5f899ad19

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and a5584c0.

📒 Files selected for processing (2)
  • src/server/claude-messages.ts
  • tests/claude-messages-endpoint.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(claude): avoid leaking main ChatGPT credential to non-canonical openai-responses providers [WRONG BRANCH] fix(claude): avoid leaking main ChatGPT credential to non-canonical openai-responses providers Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
@luvs01 luvs01 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant