Skip to content

[WRONG BRANCH] fix(claude): prevent proxy admission token disclosure - #163

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-environment-variable-vulnerability
Draft

[WRONG BRANCH] fix(claude): prevent proxy admission token disclosure#163
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-environment-variable-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent a local-admission proxy token from being injected into a user-supplied or non-loopback Anthropic endpoint when launching ocx claude.
  • Avoid placing an OpenCodex admission token into the child env when the user explicitly exported ANTHROPIC_API_KEY, which would create conflicting credentials.

Description

  • Restrict proxy admission-token injection to cases where the effective ANTHROPIC_BASE_URL is http://localhost:<port> or http://127.0.0.1:<port> and the port matches the spawned local proxy. (src/cli/claude.ts).
  • Only set ANTHROPIC_AUTH_TOKEN from config.apiKeys[0] when the destination targets the local proxy and the user has not exported ANTHROPIC_API_KEY. (src/cli/claude.ts).
  • Only set the proxy marker (PROXY_MARKER) when the effective destination targets the local proxy, preserving previous detection semantics otherwise. (src/cli/claude.ts).
  • Add focused regression tests that assert the admission token is not sent to a user-selected external gateway and that no auth token is added when the user exported ANTHROPIC_API_KEY. (tests/claude-cli.test.ts).

Testing

  • ./node_modules/.bin/bun test tests/claude-cli.test.ts — added tests passed (23 passed, 0 failed).
  • ./node_modules/.bin/bun run typecheck — typecheck passed.
  • ./node_modules/.bin/bun run privacy:scan — privacy scan passed.
  • ⚠️ ./node_modules/.bin/bun run test — full test run was attempted; unrelated GUI dependency downloads returned HTTP 403 and a different management-provider test timed out, this failure is unrelated to the claude env changes.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dde7abe4-c5e9-45a2-8f78-e8afbf9fa2b1

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 24e87f3.

📒 Files selected for processing (2)
  • src/cli/claude.ts
  • tests/claude-cli.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(claude): prevent proxy admission token disclosure [WRONG BRANCH] fix(claude): prevent proxy admission token disclosure Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant