Skip to content

[WRONG BRANCH] fix(server): bound image relay response bodies - #164

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-image-relay-response-buffering
Draft

[WRONG BRANCH] fix(server): bound image relay response bodies#164
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-image-relay-response-buffering

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The images relay previously called arrayBuffer() on upstream responses, which allowed a malicious or compromised upstream to return an arbitrarily large payload and exhaust process memory.

Description

  • Add a streaming reader readImageResponseBody() that rejects oversized responses and cancels the upstream body mid-stream rather than allocating an unbounded arrayBuffer();
  • Fast-fail when a declared Content-Length exceeds the IMAGES_RESPONSE_MAX_BYTES ceiling and otherwise incrementally accumulate bytes up to the ceiling with geometric growth of an internal buffer;
  • Replace the prior upstreamResponse.arrayBuffer() usage with the bounded reader and preserve existing relay behavior and headers when the response is accepted;
  • Add a focused regression test verifying an oversized upstream response is rejected (HTTP 502) and that the upstream body is canceled before buffering completes.

Testing

  • Ran bun run typecheck and it passed with no errors.
  • Ran bun run privacy:scan and it passed.
  • Ran the focused image tests with bun run test -- tests/server-images.test.ts, which exercised the new cases and reported the image-relay tests passing (57 passed, 0 failed for that file).
  • Ran broader bun run test during development; the focused image tests passed while unrelated test timeouts/runner contention were observed in this environment and are not caused by the image-relay change.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 002cc11a-2acd-4b70-ba6c-b3562f8673a5

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and ccb6bfe.

📒 Files selected for processing (2)
  • src/server/images.ts
  • tests/server-images.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title fix(server): bound image relay response bodies [WRONG BRANCH] fix(server): bound image relay response bodies Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant