[WRONG BRANCH] fix(server): bound image relay response bodies - #164
[WRONG BRANCH] fix(server): bound image relay response bodies#164luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
arrayBuffer()on upstream responses, which allowed a malicious or compromised upstream to return an arbitrarily large payload and exhaust process memory.Description
readImageResponseBody()that rejects oversized responses and cancels the upstream body mid-stream rather than allocating an unboundedarrayBuffer();Content-Lengthexceeds theIMAGES_RESPONSE_MAX_BYTESceiling and otherwise incrementally accumulate bytes up to the ceiling with geometric growth of an internal buffer;upstreamResponse.arrayBuffer()usage with the bounded reader and preserve existing relay behavior and headers when the response is accepted;Testing
bun run typecheckand it passed with no errors.bun run privacy:scanand it passed.bun run test -- tests/server-images.test.ts, which exercised the new cases and reported the image-relay tests passing (57 passed, 0 failed for that file).bun run testduring development; the focused image tests passed while unrelated test timeouts/runner contention were observed in this environment and are not caused by the image-relay change.Codex Task