Skip to content

[WRONG BRANCH] fix(auth): bound Codex warmup SSE streams - #166

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-sse-buffering-in-codex-warmup
Draft

[WRONG BRANCH] fix(auth): bound Codex warmup SSE streams#166
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-unbounded-sse-buffering-in-codex-warmup

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent an upstream-controlled denial-of-service where an unterminated or high-bandwidth SSE warmup response could grow the warmup parser buffer without bound and exhaust process memory.

Description

  • Add a 1 MiB hard limit (MAX_WARMUP_STREAM_BYTES) to the Codex warmup SSE drain path and count incoming bytes before decoding, throwing a typed stream_too_large CodexWarmupError when exceeded in src/codex/warmup.ts.
  • Extend the CodexWarmupError code union with stream_too_large so oversized streams follow the existing error and cleanup paths.
  • Add a regression test in tests/codex-warmup.test.ts that simulates an oversized, unterminated SSE stream and asserts the stream_too_large failure.

Testing

  • Ran bun test tests/codex-warmup.test.ts and the focused warmup tests passed (7 tests, all passing).
  • Ran bun run typecheck and bun run privacy:scan, both completed successfully.
  • Attempted bun run test (full suite); unrelated existing GUI/provider-management tests timed out during the long-running suite, so the full-suite run was not completed, but the focused warmup tests and static checks passed.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: af1a293a-2d97-4172-a4a4-6f2f163a85c2

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and ba7e576.

📒 Files selected for processing (2)
  • src/codex/warmup.ts
  • tests/codex-warmup.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(auth): bound Codex warmup SSE streams [WRONG BRANCH] fix(auth): bound Codex warmup SSE streams Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant