[WRONG BRANCH] oauth: remove legacy auth backup on destructive mutations (logout/account delete) - #167
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
auth.json.pre-multiauth) from retaining OAuth refresh tokens after destructive user actions like logout or account deletion.Description
removeLegacyBackup()and makemutateStore()acceptoptions.removeLegacyBackupso callers can opt to delete the one-time legacy backup after a destructive mutation.auth.json.pre-multiauthis removed after the store is persisted.removeCredential()andremoveAccount()so active-credential logout and explicit account deletion clear the legacy backup.tests/oauth-store-multi.test.tsverifying that a logout and an account deletion do not leaveauth.json.pre-multiauthbehind while preserving the existing non-destructive migration test.Testing
bun test tests/oauth-store-multi.test.tsand they passed (20 passed, 0 failed).bun run typecheckandbun run privacy:scan, both succeeded.bun run testduring validation; the focused OAuth tests remained green but the full suite hit unrelated timeouts in other tests (observed inoauth-login-cli-live-update.test.tsandmanagement-provider-validation.test.ts) while exercising the whole test matrix.Codex Task