Skip to content

[WRONG BRANCH] oauth: remove legacy auth backup on destructive mutations (logout/account delete) - #167

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-oauth-backup-vulnerability
Draft

[WRONG BRANCH] oauth: remove legacy auth backup on destructive mutations (logout/account delete)#167
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-oauth-backup-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent legacy single-credential backups (auth.json.pre-multiauth) from retaining OAuth refresh tokens after destructive user actions like logout or account deletion.

Description

  • Add removeLegacyBackup() and make mutateStore() accept options.removeLegacyBackup so callers can opt to delete the one-time legacy backup after a destructive mutation.
  • Only create the downgrade backup on the first non-destructive migration; destructive mutations (logout and account deletion) invoke the new removal path so auth.json.pre-multiauth is removed after the store is persisted.
  • Wire the removal behavior into both removeCredential() and removeAccount() so active-credential logout and explicit account deletion clear the legacy backup.
  • Add regression tests to tests/oauth-store-multi.test.ts verifying that a logout and an account deletion do not leave auth.json.pre-multiauth behind while preserving the existing non-destructive migration test.

Testing

  • Ran the focused auth-store tests with bun test tests/oauth-store-multi.test.ts and they passed (20 passed, 0 failed).
  • Ran type checking with bun run typecheck and bun run privacy:scan, both succeeded.
  • Ran the broader bun run test during validation; the focused OAuth tests remained green but the full suite hit unrelated timeouts in other tests (observed in oauth-login-cli-live-update.test.ts and management-provider-validation.test.ts) while exercising the whole test matrix.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1587f43a-0384-4b84-8436-3200a29f31c0

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and e7a754d.

📒 Files selected for processing (2)
  • src/oauth/store.ts
  • tests/oauth-store-multi.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title oauth: remove legacy auth backup on destructive mutations (logout/account delete) [WRONG BRANCH] oauth: remove legacy auth backup on destructive mutations (logout/account delete) Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant