[WRONG BRANCH] fix: keep hidden reasoning out of transparent envelopes - #168
[WRONG BRANCH] fix: keep hidden reasoning out of transparent envelopes#168luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
thinkingtext into a base64ocxr1:envelope and later decoded it, which exposed hidden chain-of-thought to clients and downstream adapters.Description
txtin reasoning envelopes by removingtxtfromReasoningEnvelopeand ensuringencodeReasoningEnvelope/decodeReasoningEnvelopeonly carrysig,red, andkrcas opaque payloads (seesrc/responses/reasoning-envelope.ts).thinkingor raw reasoning text intoencrypted_contentwhenhideThinkingSummaryis enabled, while keeping the signature and redacted blocks round-tripable (seesrc/bridge.ts).txtinto assistantthinkingcontent during parsing so legacy/plaintext envelopes no longer become replayed assistant thinking (seesrc/responses/parser.ts).tests/anthropic-thinking-signature.test.tsandtests/bridge-raw-reasoning-hidden.test.ts).Testing
bun run typecheckandbun run privacy:scan, both succeeded.bun test tests/anthropic-thinking-signature.test.ts tests/bridge-raw-reasoning-hidden.test.ts tests/bridge.test.ts, which exercise the ocxr1 envelope, hidden reasoning, and bridge behavior; the modified tests covering hidden-text leakage and envelope handling passed; the test run reported one environment-specific failure unrelated to these changes (node:zlib.zstdDecompressSyncmissing in the active Bun runtime).bun run testlocally to validate integration scope; the changed areas exercised by the suite passed, with an unrelated external-proxy timeout observed in the long-running portion of the full suite.Codex Task