Skip to content

[WRONG BRANCH] fix(providers): allow same-origin connection tests - #169

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-hidden-connection-test
Draft

[WRONG BRANCH] fix(providers): allow same-origin connection tests#169
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-hidden-connection-test

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The connection-test UI and handler treated an empty apiBase as absent, which hid the Test connection control for the default same-origin GUI deployment even though fetch(${apiBase}/api/...) with apiBase === "" should resolve to /api/... and work.

Description

  • Relax the early-exit and rendering checks to distinguish a missing apiBase from an intentionally empty same-origin base by checking apiBase === undefined and apiBase !== undefined respectively in gui/src/components/provider-workspace/ProviderOverview.tsx.
  • Keep the existing fetch URL construction ( ${apiBase}/api/providers/test?name=... ) so an empty apiBase produces the same-origin /api/providers/test?... request.
  • Add a focused regression test connection test supports the default same-origin API base to gui/tests/provider-overview-notes-save.test.tsx that verifies the button renders with apiBase = "", the same-origin request is issued, and a successful result is displayed.

Testing

  • Ran the targeted tests with cd gui && bun test tests/provider-overview-notes-save.test.tsx, and the file's tests (including the new case) passed (6 pass, 0 fail).
  • Ran cd gui && bun run lint and cd gui && bun run build, and both completed successfully (Vite build emitted only existing chunk-size warnings).
  • Ran the broader GUI test run cd gui && bun test tests; the targeted regression passed but the full suite reported unrelated failures in other tests and one environment incompatibility under the local Bun version, which are not caused by this focused change.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d464a75d-a546-466e-8b2b-578fecd784cd

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 05e4640.

📒 Files selected for processing (2)
  • gui/src/components/provider-workspace/ProviderOverview.tsx
  • gui/tests/provider-overview-notes-save.test.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(providers): allow same-origin connection tests [WRONG BRANCH] fix(providers): allow same-origin connection tests Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant