[WRONG BRANCH] fix(providers): allow same-origin connection tests - #169
[WRONG BRANCH] fix(providers): allow same-origin connection tests#169luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
apiBaseas absent, which hid the Test connection control for the default same-origin GUI deployment even thoughfetch(${apiBase}/api/...)withapiBase === ""should resolve to/api/...and work.Description
apiBasefrom an intentionally empty same-origin base by checkingapiBase === undefinedandapiBase !== undefinedrespectively ingui/src/components/provider-workspace/ProviderOverview.tsx.${apiBase}/api/providers/test?name=...) so an emptyapiBaseproduces the same-origin/api/providers/test?...request.connection test supports the default same-origin API basetogui/tests/provider-overview-notes-save.test.tsxthat verifies the button renders withapiBase = "", the same-origin request is issued, and a successful result is displayed.Testing
cd gui && bun test tests/provider-overview-notes-save.test.tsx, and the file's tests (including the new case) passed (6 pass, 0 fail).cd gui && bun run lintandcd gui && bun run build, and both completed successfully (Vite build emitted only existing chunk-size warnings).cd gui && bun test tests; the targeted regression passed but the full suite reported unrelated failures in other tests and one environment incompatibility under the local Bun version, which are not caused by this focused change.Codex Task