Skip to content

[WRONG BRANCH] fix: correct stale-contract scan exit handling - #171

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-stale-contract-scan-issue
Draft

[WRONG BRANCH] fix: correct stale-contract scan exit handling#171
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-stale-contract-scan-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The denylist-style stale-contract-scan used rg -n whose exit semantics are inverted for this use case (exit 0 = match, exit 1 = no matches), causing stale references to pass the final gates.

Description

  • Introduce an optional successExitCodes?: number[] on GateSpec and make runGateSequence accept per-gate success codes while preserving [0] as the default for existing gates.
  • Configure the stale-contract-scan gate to succeed only when rg returns 1 (no matches) by setting successExitCodes: [1] in finalGatePlan.
  • Add a focused regression test in tests/openai-provider-option-tooling.test.ts that validates the three ripgrep outcomes: match (0) fails, no-match (1) passes, and error codes fail.

Testing

  • Ran bun test tests/openai-provider-option-tooling.test.ts and the updated tooling tests passed.
  • Ran bun run typecheck and type checking completed successfully.
  • Ran git diff --check which reported no issues for the change set.
  • Attempted full bun run test but the broader suite encountered an unrelated pre-existing failure (a timed-out test in management-provider-validation.test.ts that returned 401 instead of 400), so the full suite was not completed in this run.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 38d70b65-4395-4ee7-969d-69986fbfeee2

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 0e4a89f.

📒 Files selected for processing (2)
  • scripts/openai-provider-option-final-gates.ts
  • tests/openai-provider-option-tooling.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix: correct stale-contract scan exit handling [WRONG BRANCH] fix: correct stale-contract scan exit handling Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant