Skip to content

[WRONG BRANCH] fix(gui): remove disabled full-config JSON editor flow and add regression test - #173

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-gui-config-saving-after-put-disable
Draft

[WRONG BRANCH] fix(gui): remove disabled full-config JSON editor flow and add regression test#173
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-gui-config-saving-after-put-disable

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The server now rejects PUT /api/config and the Providers page still exposed a raw JSON editor that attempted to save via that disabled endpoint, causing a functional regression.
  • The goal is to remove the unusable save path from the dashboard surface so the UI does not present a broken Save flow.

Description

  • Remove the useJsonConfigEditor wiring and related props that exposed the full-config Save controls from gui/src/pages/Providers.tsx so the dashboard no longer calls PUT /api/config through the JSON editor.
  • Stop passing jsonEditor, onEditConfig, jsonSaving, and the onSaveJson/onDiscardJson handlers into ProviderWorkspaceShell / ProvidersPageModals.
  • Add a focused regression test gui/tests/providers-json-editor-disabled.test.ts that asserts the Providers page source no longer references the disabled editor flow.

Testing

  • ✅ Ran the focused test with cd gui && bun test tests/providers-json-editor-disabled.test.ts, which passed.
  • ✅ Ran cd gui && bun run lint and cd gui && bun run build, both succeeded.
  • ✅ Ran bun run typecheck, which completed successfully.
  • ⚠️ Ran the broader GUI test suite with cd gui && bun test and the repository bun run test; unrelated environment-sensitive failures appeared (for example logs-auto-refresh.test.tsx requires jest.advanceTimersByTime in this test runtime and Playwright/Chromium could not be installed here), but those failures are not caused by this change.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4318fc03-9aec-4e28-8b09-84fa2d7a9c56

📥 Commits

Reviewing files that changed from the base of the PR and between 57140d6 and 8c45cef.

📒 Files selected for processing (2)
  • gui/src/pages/Providers.tsx
  • gui/tests/providers-json-editor-disabled.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 8, 2026
@github-actions github-actions Bot changed the title fix(gui): remove disabled full-config JSON editor flow and add regression test [WRONG BRANCH] fix(gui): remove disabled full-config JSON editor flow and add regression test Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant