[WRONG BRANCH] fix(gui): remove disabled full-config JSON editor flow and add regression test - #173
[WRONG BRANCH] fix(gui): remove disabled full-config JSON editor flow and add regression test#173luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
PUT /api/configand the Providers page still exposed a raw JSON editor that attempted to save via that disabled endpoint, causing a functional regression.Description
useJsonConfigEditorwiring and related props that exposed the full-config Save controls fromgui/src/pages/Providers.tsxso the dashboard no longer callsPUT /api/configthrough the JSON editor.jsonEditor,onEditConfig,jsonSaving, and theonSaveJson/onDiscardJsonhandlers intoProviderWorkspaceShell/ProvidersPageModals.gui/tests/providers-json-editor-disabled.test.tsthat asserts the Providers page source no longer references the disabled editor flow.Testing
cd gui && bun test tests/providers-json-editor-disabled.test.ts, which passed.cd gui && bun run lintandcd gui && bun run build, both succeeded.bun run typecheck, which completed successfully.cd gui && bun testand the repositorybun run test; unrelated environment-sensitive failures appeared (for examplelogs-auto-refresh.test.tsxrequiresjest.advanceTimersByTimein this test runtime and Playwright/Chromium could not be installed here), but those failures are not caused by this change.Codex Task