[WRONG BRANCH] Bound retained Cursor blob ID keys - #178
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request currently targets @luvs01 Please retarget this PR to Its title has been prefixed with This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCursor blob storage now tracks retained key-string memory separately from payload memory. Large blob IDs use bounded SHA-256 keys. Metrics, snapshots, deletion, eviction, reset behavior, and tests now include key-byte accounting. ChangesCursor blob memory accounting
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Star lidge-jun/opencodex? Yes / No
Motivation
Description
h:hex passthrough; larger IDs becomed:+ SHA-256 hex) to bound retained key length.blobKeyBytescounter and include key bytes in all relevant accounting paths, including insertion, deletion, eviction, snapshot, and metrics.Testing
bun test tests/cursor-blob.test.tswhere the Cursor-focused tests passed (59 passed, 0 failed).bun run typecheckandbun run privacy:scan, both succeeded.bun run test; Cursor tests passed but the full-suite run encountered unrelated environment-sensitive timeouts in some provider/model-discovery and combo-management tests (these failures are not related to the Cursor KV fix).Codex Task
Summary by CodeRabbit
Bug Fixes
Reliability