Skip to content

[WRONG BRANCH] harness: drain nested deferred timers and preserve timer arguments in PR-target tests - #181

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-deferred-work-escape-in-harness
Draft

[WRONG BRANCH] harness: drain nested deferred timers and preserve timer arguments in PR-target tests#181
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-deferred-work-escape-in-harness

Conversation

@luvs01

@luvs01 luvs01 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The PR-target test harness shadowed Node timer APIs but discarded timer arguments and only drained a single batch of deferred callbacks, allowing nested deferred work and argument-dependent callbacks to escape recording.
  • The goal is to make the harness faithfully reproduce Node/GitHub Actions semantics so deferred callbacks (including timer->microtask nests and callbacks that use setTimeout arguments) are executed and recorded during the test run.

Description

  • Preserve timer callback arguments by capturing and replaying the callback with its original arguments for setTimeout, setInterval, and setImmediate.
  • Add distinct capture helpers (captureTimer, captureImmediate, captureMicrotask) and wire them into the fake globalThis and returned runtime surface so timer semantics match production.
  • Drain deferred work until the queue is empty using a loop instead of a one-shot splice(0), ensuring callbacks scheduled while draining are executed.
  • Add a focused regression test in tests/ci-workflows.test.ts that asserts nested timer->microtask writes and argument-dependent timer callbacks are recorded by the harness.

Testing

  • Ran bun run typecheck which completed successfully.
  • Ran bun run privacy:scan which completed successfully.
  • Exercised the new regression with bun test tests/ci-workflows.test.ts, and the new nested-deferred/timer-argument test passed when executed under the repository-compatible Bun runtime; running the suite under an older local Bun (v1.2.x) showed unrelated failures (missing Bun.YAML) due to runtime differences.
  • Attempted a full bun run test; the run progressed and the focused changes are covered, but unrelated pre-existing timeouts and environment-dependent failures in the full suite prevented a completely clean run in this environment.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 31f465aa-66b0-4dcc-924c-8e657dc761d3

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9c0ef and 25925a0.

📒 Files selected for processing (2)
  • tests/ci-workflows.test.ts
  • tests/helpers/enforce-pr-target-harness.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

⚠️ Wrong target branch

This pull request currently targets main, but pull requests must target one of dev.

@luvs01 Please retarget this PR to dev. All contributions go to dev; main receives only release promotions. See our Contributing guide for details. Thanks! 🙏

Its title has been prefixed with [WRONG BRANCH].

This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions github-actions Bot changed the title harness: drain nested deferred timers and preserve timer arguments in PR-target tests [WRONG BRANCH] harness: drain nested deferred timers and preserve timer arguments in PR-target tests Aug 8, 2026
@github-actions
github-actions Bot marked this pull request as draft August 8, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant