[WRONG BRANCH] harness: drain nested deferred timers and preserve timer arguments in PR-target tests - #181
[WRONG BRANCH] harness: drain nested deferred timers and preserve timer arguments in PR-target tests#181luvs01 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
This pull request currently targets @luvs01 Please retarget this PR to Its title has been prefixed with This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again. |
Motivation
Description
setTimeout,setInterval, andsetImmediate.captureTimer,captureImmediate,captureMicrotask) and wire them into the fakeglobalThisand returned runtime surface so timer semantics match production.splice(0), ensuring callbacks scheduled while draining are executed.tests/ci-workflows.test.tsthat asserts nested timer->microtask writes and argument-dependent timer callbacks are recorded by the harness.Testing
bun run typecheckwhich completed successfully.bun run privacy:scanwhich completed successfully.bun test tests/ci-workflows.test.ts, and the new nested-deferred/timer-argument test passed when executed under the repository-compatible Bun runtime; running the suite under an older local Bun (v1.2.x) showed unrelated failures (missingBun.YAML) due to runtime differences.bun run test; the run progressed and the focused changes are covered, but unrelated pre-existing timeouts and environment-dependent failures in the full suite prevented a completely clean run in this environment.Codex Task