Adding YOLOX native support#226
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughYOLOX support was added across checkpoint detection, model construction, NNArchive export, CLI conversion, registry wiring, preprocessing, model catalogs, documentation, and end-to-end tests. ChangesYOLOX conversion pipeline
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as convert CLI
participant Detection as detect_version
participant Registry as conversion_registry
participant Exporter as YoloXExporter
participant Archive as make_nn_archive
CLI->>Detection: detect YOLOX checkpoint
Detection-->>CLI: return YOLOX_CONVERSION
CLI->>Registry: create exporter for yolox
Registry-->>CLI: return YoloXExporter
CLI->>Exporter: export_nn_archive with BGR encoding
Exporter->>Archive: generate NNArchive with YOLOExtendedParser
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/yolox/YOLOX`:
- Line 1: Update the tools/yolox/YOLOX gitlink to a valid, fetchable commit SHA
from its configured YOLOX remote, preserving the intended release or branch.
Verify the pinned commit can be fetched and initialize the submodule
successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c03c4f0e-6310-465e-8b54-af5faa4e771d
⛔ Files ignored due to path filters (1)
media/coverage_badge.svgis excluded by!**/*.svg
📒 Files selected for processing (17)
.gitmodulesREADME.mdpyproject.tomltests/conftest.pytests/constants.pytests/e2e_shards.pytests/nnarchive_output_checks.pytests/test_unittests.pytests/test_yolox_exporter.pytools/conversion_registry.pytools/main.pytools/modules/exporter.pytools/version_detection/__init__.pytools/version_detection/version_detection.pytools/yolox/YOLOXtools/yolox/__init__.pytools/yolox/yolox_exporter.py
Test Results 6 files 6 suites 14m 45s ⏱️ Results for commit 9e800f1. |
Purpose
.pthstate-dict checkpoints.yolov6r1, reusing its output names and grid decoder metadata.Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO
Summary by CodeRabbit