chore: cleaning code base#658
Merged
Merged
Conversation
Owner
Author
|
It also fixes: [#615] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and fixes across Android, iOS, documentation, and tooling. The most significant changes focus on increasing Android security robustness, improving code maintainability, updating dependencies, and refining documentation for clarity. Below are the most important updates:
Android Security and Stability Improvements:
CryptoManagerinandroid/src/main/java/com/sensitiveinfo/internal/crypto/CryptoManager.ktto centralize cipher initialization and error handling in a newinitCiphermethod, reducing code repetition and improving maintainability. [1] [2] [3]setUnlockedDeviceRequired, preventing crashes on Android 12–14 devices lacking a secure screen lock. This change addresses a known Android platform issue and ensures compatibility. [1] [2]CryptoManagerand its usage to require aContextparameter, enabling the secure lock screen check. [1] [2] [3]Documentation and Clarity:
README.mdanddocs/PERFORMANCE.mdto clarify security details, simplify language, and remove redundant or outdated explanations, making the documentation more concise and accurate. [1] [2] [3] [4] [5]HybridSensitiveInfo.swiftby streamlining the explanation for the upsert logic and clarifying the reasoning behind force-deletion and retry behavior.Tooling and Dependency Updates:
react,react-native, and related tooling, to their latest versions for improved compatibility and security.biome.jsonconfiguration to the latest schema, refined linter rules for better code quality, and added targeted overrides for specific directories. [1] [2] [3] [4]iOS Project Configuration:
PODFILE_DIRvariable to the Xcode project configuration to improve CocoaPods integration. [1] [2]Android Code Comments and Legacy Handling:
HybridSensitiveInfo.kt.These changes collectively improve security, maintainability, and clarity across the project.