Conversation
mourner
requested review from
ibesora
and removed request for
a team and
ibesora
mourner
changed the title
This was referenced Jun 25, 2026
Merged
urschrei
added a commit
to urschrei/polylabel-rs
that referenced
this pull request
Jun 28, 2026
Decompose each ring into edges grouped into fixed-size blocks (BLOCK_SIZE=32), precomputing one bounding box per block once per polylabel call (PreparedPolygon). The per-cell distance scan uses a cheap point-to-bbox lower bound to skip a whole block when it can neither hold a nearer edge nor flip the ray-cast parity. The per-segment distance is still geo's Euclidean point-to-Line; only the AABB lower bound is computed inline (geo's point-to-Rect allocates per call). See also: mapbox/polylabel#127 Signed-off-by: Stephan Hügel <shugel@tcd.ie>
urschrei
added a commit
to urschrei/polylabel-rs
that referenced
this pull request
Jun 28, 2026
Decompose each ring into edges grouped into fixed-size blocks (BLOCK_SIZE=32), precomputing one bounding box per block once per polylabel call (PreparedPolygon). The per-cell distance scan uses a cheap point-to-bbox lower bound to skip a whole block when it can neither hold a nearer edge nor flip the ray-cast parity. The per-segment distance is still geo's Euclidean point-to-Line; only the AABB lower bound is computed inline (geo's point-to-Rect allocates per call). See also: mapbox/polylabel#127 Signed-off-by: Stephan Hügel <shugel@tcd.ie>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance-focused rewrite of the core distance computation:
Float64Array, sized upfront; block layout is re-derived in the scan fromcoords/ringEnds, so no auxiliary index arrays). In the per-cell distance scan, a cheap point-to-bbox lower bound skips a whole block in O(1) when it can neither beat the current nearest distance nor flip the ray-cast parity. Polygon rings are spatially coherent, so most blocks are far from any given cell center and get skipped wholesale.Float64Array(coords) with per-ring end offsets (ringEnds), replacing nested array-of-[x, y]iteration. This removes pointer-chasing in the hot distance loop for cache-friendly access.pointToPolygonDistnow takes a distance threshold (maxD). A cell is only useful if it can beat the current best or is worth subdividing; once the center is provably within the threshold of the outline, the scan bails out early instead of measuring the whole outline.