static homepage, need to double check and understand changes - #232
Open
EMPN2350GirirajShankar wants to merge 1 commit into
Open
static homepage, need to double check and understand changes#232EMPN2350GirirajShankar wants to merge 1 commit into
EMPN2350GirirajShankar wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Definition Duplication — Two Representations
Even though routeRegistry.ts exists, App.tsx still manually constructs with individual elements. The registry and the router tree are two separate representations of the same routes.
Possible fix: Use React Router's data-router API where a single route object tree feeds both the client router and the server renderer. The registry becomes the route tree.
Redirects & Sitemap Semantics
The registry has redirect routes like:
On a static host (GitHub Pages), /homev3 needs an HTML file that redirects to /. If that file doesn't have
<meta name="robots" content="noindex">and<link rel="canonical" href="https://maqsoftware.com/">, search engines could index both / and /homev3 as separate pages → duplicate content penalty.Based on my understanding this is the Architecture for this PR:
This is a well-architected foundation. The route registry alone eliminates a major maintenance burden. The SSR/prerender pipeline, while scoped to home page initially, is correctly structured for expansion. The blocking issues are all small, mechanical fixes — none require architectural rework.